Align GitHub workflow/job run conditions #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Apr 15, 2024
WillChilds-Klein
approved these changes
Apr 16, 2024
| pull_request: | ||
| branches: | ||
| - '*' | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} |
There was a problem hiding this comment.
is pull_request populated on push-type events? i don't see any such fields in the docs...
There was a problem hiding this comment.
I believe for pushes to repository branches the value of the group here would effectively be only the workflow name. This means that pushing (or merging) multiple commits in quick succession would cause CI workflows to be cancelled. A better choice might be github.ref_name: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.