-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve backwards compatability for the TLS transfer parser #1337
Improve backwards compatability for the TLS transfer parser #1337
Conversation
Still need to bump |
I could bump it or just leave it as-is. There is no functional difference. I left it out in this PR with no real arguments for why. |
bumped config parser version: ed630ee |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 421 421
Lines 71016 71021 +5
=======================================
+ Hits 54308 54312 +4
- Misses 16708 16709 +1 ☔ View full report in Codecov by Sentry. |
Allows the parser to deserialise TLS transfer state as long as the state version is as old or older than the parser.
### Issues: Addresses P147941517 ### Description of changes: Backports #1322 and #1337 to the fips-2022-11-02 branch. This changes does not modify the FIPS module boundary. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Will Childs-Klein <childw@amazon.com> Co-authored-by: torben-hansen <50673096+torben-hansen@users.noreply.github.com>
Description of changes:
Allows the parser to deserialise TLS transfer state as long as the state version is as old or older than the parser.
#1322 added a few more (optional) fields to the TLS transfer format. We want this to impose a version bump. But the parser currently doesn't allow inputting state serialised through an older parser. Improve backwards compatibility to allow future version bumps.
This makes deploying to a large fleet with a long delta of software versions being out-of-sync much easier.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.