Enable Arm SHA384 proofs in AWS-LC CI #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennyannn
force-pushed
the
yppe/enable-arm-sha384
branch
2 times, most recently
from
410af73 to
c794032
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 76.75% 76.72% -0.04%
==========================================
Files 422 422
Lines 71186 71186
==========================================
- Hits 54638 54616 -22
- Misses 16548 16570 +22 ☔ View full report in Codecov by Sentry. |
pennyannn
force-pushed
the
yppe/enable-arm-sha384
branch
4 times, most recently
from
1d5f407 to
f2d4b2a
Compare
pennyannn
force-pushed
the
yppe/enable-arm-sha384
branch
from
f2d4b2a to
8613ba9
Compare
|
NSym is only specific to aarch64, right? Should that be reflected in the folder structure and/or the file naming? |
Good idea. I've updated the files. |
pennyannn
force-pushed
the
yppe/enable-arm-sha384
branch
from
919b1e7 to
e8d7ca8
Compare
nebeid
previously approved these changes
Dec 11, 2023
samuel40791765
previously approved these changes
Dec 11, 2023
pennyannn
dismissed stale reviews from samuel40791765 and nebeid
via
5cfa821
samuel40791765
approved these changes
Dec 11, 2023
nebeid
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
None
Description of changes:
This PR enables NSym and SAW proofs for SHA384 on Arm machines (Graviton2 and Graviton3). Specifically,
ubuntu2004_clang10x_formal_verification_quickchecktoubuntu2004_clang10x_formal_verification_saw_x86_64and a bunch of other renamingubuntu-22.04_clang-14x_formal-verification-nsym-aarch64andubuntu-20.04_clang-10x_formal-verification-saw-aarch64ubuntu2004_clang10x_formal_verification_saw_aarch64andubuntu2204_clang14x_formal_verification_nsym_aarch64in linux-x86 runsCall-outs:
None
Testing:
CI run succeeds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.