Upstream merge 2023 12 11 #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1356 +/- ##
==========================================
+ Coverage 76.71% 76.73% +0.02%
==========================================
Files 422 422
Lines 71186 71197 +11
==========================================
+ Hits 54611 54636 +25
+ Misses 16575 16561 -14 ☔ View full report in Codecov by Sentry. |
This function hasn't done anything since 2015, when https://boringssl-review.googlesource.com/5792 made it a no-op. Also move RAND_get_system_entropy_for_custom_prng under obscure functions. It's usually not what you want. Change-Id: Ica57552792acff3c5991e6db09c15112db09d133 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61505 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com> Auto-Submit: David Benjamin <davidben@google.com> (cherry picked from commit 8267582590020ca2877592084f3a56b2f6e3209b)
nebeid
force-pushed
the
upstream-merge-2023-12-11
branch
from
fc90390 to
7cda686
Compare
This replaces our dynamically creating singleton EC_GROUPs from curve
data with static EC_GROUP instances.
They're just shy of being fully static because delocate still forces us
go to through CRYPTO_once to initialize structures with pointers.
(Though, without delocate, the loader would need similar initialization
via a runtime relocation.)
This means we can now have functions like EC_group_p256(), analogous to
EVP_sha256(). These are infallible functions that return const EC_GROUP
pointers. Although there is an initial 2KiB hit to binary size (now we
precompute a few more Montgomery values), I'm hoping it'll eventually
help binaries that only use a few of the curves to drop the others. Also
it removes some locks used to initialize the static curve objects, as
well as removing an annoying error condition.
AWS-LC:
- migrated the support for secp256k1 to the new static initialisation:
-- added it to make_tables.go, and hence, to builtin_curves.h
-- added an EC_GROUP for it in ec.c and included it in ec_asn1.c and ec.h
- P521:
-- added non-Montgomery values to builtin_curves.h in order to support
EC_GFp_nistp521_method()
-- preserved the handling of different bit sizes for the digits
representation required by P-521 tables
Bug: 20
Change-Id: Id051c5439f2b2fe2b09bf10964d656503ee27d9e
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60931
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
(cherry picked from commit 417069f8b2fd6dd4f8c2f5f69de7c038a2397050)
nebeid
force-pushed
the
upstream-merge-2023-12-11
branch
from
7cda686 to
e166375
Compare
dkostic
approved these changes
Dec 18, 2023
skmcgrail
approved these changes
Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merging from Upstream 2 commits on Jul 11 google/boringssl@8267582 and google/boringssl@417069f
Call-outs:
See internal document as well as "AWS-LC" notes inserted in some of the commit messages for additions/deviations from the upstream commit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.