Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake GitHub Actions CI #1367

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add CMake GitHub Actions CI #1367

merged 1 commit into from
Jan 9, 2024

Conversation

skmcgrail
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc4e281) 76.80% compared to head (2ec5d40) 76.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   76.80%   76.76%   -0.04%     
==========================================
  Files         422      422              
  Lines       71259    71259              
==========================================
- Hits        54732    54705      -27     
- Misses      16527    16554      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skmcgrail skmcgrail marked this pull request as ready for review December 19, 2023 23:24
@skmcgrail skmcgrail requested a review from a team as a code owner December 19, 2023 23:24
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice solution of building new containers in each task to get around version-namespacing CMake builds!

@skmcgrail skmcgrail merged commit 7dc34d3 into aws:main Jan 9, 2024
33 of 34 checks passed
@skmcgrail skmcgrail deleted the cmake-ci branch January 9, 2024 18:29
dougch pushed a commit to dougch/aws-lc that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants