Add assertions and unify tmpfile uniqueptr #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
tmpfile-fix
branch
from
e627371 to
520bb04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
==========================================
+ Coverage 76.75% 76.77% +0.01%
==========================================
Files 422 422
Lines 71259 71259
==========================================
+ Hits 54697 54706 +9
+ Misses 16562 16553 -9 ☔ View full report in Codecov by Sentry. |
nebeid
approved these changes
Dec 22, 2023
WillChilds-Klein
approved these changes
Dec 22, 2023
dougch
pushed a commit
to dougch/aws-lc
that referenced
this pull request
Jan 30, 2024
Static Analysis was complaining about our lack of assertions. I also unified our usage of tmpfile deleters while I was at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
V1159778876Description of changes:
Static Analysis was complaining about our lack of assertions. I also unified our usage of
tmpfiledeleters while I was at it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.