Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Provide a compile option to disable AVX512-specific optimizations. #1380

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[Backport] Provide a compile option to disable AVX512-specific optimizations. #1380

merged 1 commit into from
Jan 5, 2024

Conversation

skmcgrail
Copy link
Member

Description of changes:

Backports #945 to the fips-2022-11-02 branch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nebeid @skmcgrail
Provide a compile option to disable AVX512-specific optimizations. (a…
93fe41d 
…ws#945)

- The new flag name ends with "512AVX" instead of "AVX512" so that it doesn't include the entire flag
-DMY_ASSEMBLER_IS_TOO_OLD_FOR_AVX and match it in the Perl files checks.

- avx512 is disabled when avx is.

(cherry picked from commit 301dce9)
@skmcgrail skmcgrail requested a review from a team as a code owner January 3, 2024 23:25
@skmcgrail skmcgrail changed the base branch from main to fips-2022-11-02 January 3, 2024 23:25
@skmcgrail skmcgrail requested a review from a team as a code owner January 3, 2024 23:25
torben-hansen
torben-hansen reviewed Jan 4, 2024
View reviewed changes
crypto/fipsmodule/modes/gcm_test.cc
@@ -189,6 +189,7 @@ TEST(GCMTest, ABI) {
}
}
}
#if !defined(MY_ASSEMBLER_IS_TOO_OLD_FOR_512AVX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be guarded(?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically no if we don't support building and/or running the tests on such an older platform. But this is inline with what is in the main branch so I'm going to keep it.

@skmcgrail skmcgrail merged commit 0ff9f3a into aws:fips-2022-11-02 Jan 5, 2024
4 of 5 checks passed
@skmcgrail skmcgrail deleted the backport-fips-2022-11-02 branch January 5, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torben-hansen torben-hansen torben-hansen approved these changes

@darylmartin100 darylmartin100 darylmartin100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmcgrail @torben-hansen @darylmartin100 @nebeid