Use standard CMake options to specify C/C++ language standard, add BoringSSL to speed test #1410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-2257 CryptoAlg-1208
Description of changes:
CMAKE_C_STANDARD
optionCall-outs:
BoringSSL already migrated to using CMAKE_C_STANDARD which we initially skipped because they also bumped up to C11 while we want to maintain C99 support.
Testing:
Built locally. Looking at the build out I verified the default and optional override are being set as expected:
cmake -GNinja
build.ninja
contains-std=gnu99
and-std=gnu++11
With optional override:
cmake -GNinja -DCMAKE_CXX_STANDARD=14 -DCMAKE_C_STANDARD=11
build.ninja
contains-std=gnu11
and-std=gnu++14
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.