fix X509V3_EXT_METHODs for ocsp nonce extension #1603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
V1391929042
Description of changes:
This backports more of the changes done in 736a283 to reintroduce the "old-style"
X509V3_EXT_METHOD
s.Although we're reintroducing the methods we discourage using, I've added checks to ensure that these are only used with
NID_id_pkix_OCSP_Nonce
. The assertion inX509V3_EXT_add
is kept so that we continue to only allow |ASN1_ITEM|-based extensions for consumers that add their own.Call-outs:
I've abstracted out the freeing logic to
x509v3_ext_free_with_method
. This used to be all over the place.Testing:
New test case added
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.