Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ocsp get id #1609

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Add support for ocsp get id #1609

merged 6 commits into from
Jun 4, 2024

Conversation

ecdeye
Copy link
Contributor

@ecdeye ecdeye commented May 28, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Description:
Added "OCSP_onereq_get0_id," which is an OCSP function available in OpenSSL, but missing in AWS-LC

@ecdeye ecdeye requested a review from a team as a code owner May 28, 2024 21:39
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (8258d73) to head (8390020).

Files Patch % Lines
crypto/ocsp/ocsp_server.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
+ Coverage   78.05%   78.06%   +0.01%     
==========================================
  Files         562      562              
  Lines       94600    94609       +9     
  Branches    13575    13577       +2     
==========================================
+ Hits        73840    73858      +18     
+ Misses      20168    20159       -9     
  Partials      592      592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crypto/ocsp/ocsp_server.c Outdated Show resolved Hide resolved
justsmth
justsmth previously approved these changes May 30, 2024
@justsmth justsmth self-requested a review May 30, 2024 22:06
@justsmth justsmth merged commit c7759e4 into aws:main Jun 4, 2024
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants