Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use params to build_compilation_database.sh #1647

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

Propogates script parameters to cmake command

Testing:

❯ ./util/build_compilation_database.sh -DFIPS=1 -DBUILD_SHARED_LIBS=1
...
+ mkdir -p /var/folders/bd/5rrlftjx2098f44h7jbj3n400000gr/T/tmp.69gTlsxzTf/AWS-LC-BUILD
+ cmake /Users/justsmth/repos/aws-lc -B /var/folders/bd/5rrlftjx2098f44h7jbj3n400000gr/T/tmp.69gTlsxzTf/AWS-LC-BUILD -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DFIPS=1 -DBUILD_SHARED_LIBS=1
...
...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner June 20, 2024 11:48
@justsmth justsmth merged commit b2bbd9c into aws:main Jun 25, 2024
97 of 99 checks passed
@justsmth justsmth deleted the compile-db-params branch June 25, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants