ec_nistp table generation for scalar multiplication #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 78.27% 78.21% -0.06%
==========================================
Files 567 571 +4
Lines 95227 95464 +237
Branches 13671 13704 +33
==========================================
+ Hits 74538 74670 +132
- Misses 20095 20185 +90
- Partials 594 609 +15 ☔ View full report in Codecov by Sentry. |
dkostic
force-pushed
the
ec-nistp-scalar-mul-gen-table
branch
from
f9276cb to
c72f9a0
Compare
crypto/fipsmodule/ec/ec_nistp.c
Outdated
| const size_t felem_num_bytes = felem_num_limbs * sizeof(ec_nistp_felem_limb); | ||
|
|
||
| // table[0] <-- P. | ||
| OPENSSL_memcpy(&table[felem_num_limbs * 0], x_in, felem_num_bytes); |
There was a problem hiding this comment.
Suggested change
| OPENSSL_memcpy(&table[felem_num_limbs * 0], x_in, felem_num_bytes); | |
| OPENSSL_memcpy(&table[0], x_in, felem_num_bytes); |
There was a problem hiding this comment.
Remove all redundant multiplications...
crypto/fipsmodule/ec/ec_nistp.c
Outdated
| // table[0] <-- P. | ||
| OPENSSL_memcpy(&table[felem_num_limbs * 0], x_in, felem_num_bytes); | ||
| OPENSSL_memcpy(&table[felem_num_limbs * 1], y_in, felem_num_bytes); | ||
| OPENSSL_memcpy(&table[felem_num_limbs * 2], z_in, felem_num_bytes); |
There was a problem hiding this comment.
precompute index since it's the same 3 times in a row.
There was a problem hiding this comment.
I find it more clear this way. what's the reason you'd like it precomputed?
There was a problem hiding this comment.
x_index, y_index, z_index. That seems more clear to me being able to name it. And it's faster.
nebeid
reviewed
Jul 5, 2024
torben-hansen
approved these changes
Jul 8, 2024
nebeid
approved these changes
Jul 8, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Generating the precomputed table for scalar multiplication for curves
P-384 and P-521 was implemented for each curve separately.
This commit refactors the code such that a single implementation
can be used with both curves. It is a step towards moving the whole
scalar multiplication code to ec_nistp.c.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.