Better support legacy DES customers #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
- Coverage 78.27% 78.26% -0.02%
==========================================
Files 566 567 +1
Lines 95185 95224 +39
Branches 13664 13671 +7
==========================================
+ Hits 74502 74523 +21
- Misses 20088 20107 +19
+ Partials 595 594 -1 ☔ View full report in Codecov by Sentry. |
|
FYI |
to perform expected checks before using the key. Update exisitin internal usage to DES_set_key_unchecked to maintain existing behavior.
andrewhop
force-pushed
the
des_utility_functions
branch
2 times, most recently
from
670f27e to
e1cb0d5
Compare
skmcgrail
approved these changes
Jun 28, 2024
torben-hansen
approved these changes
Jun 28, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-2421
Description of changes:
No one should start using these DES functions, or continue using DES in general. However, for legacy customers that can't change this PR adds a few small utility functions and aligns AWS-LC with the behavior they expect from OpenSSL.
Call-outs:
I updated DES_set_key to perform the same checks as OpenSSL and updated internal usages to use DES_set_key_unchecked.
Testing:
Added new tests and ensured existing tests still pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.