Handle Windows not supporting static array dimension #1912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2241
Description of changes:
awslabs/s2n-bignum#98 handles Windows not supporting static array dimensions. We have our own header files with function declarations for s2n-bignum. Hence that work was never ported automatically.
Adopt same detection approach as in referenced PR. MSVC doesn't support it, neither does C++. So, try to detect those cases as well as if variable-length arrays aren't supported.
Previous solution
Support it now but use our own macro
OEPNSSL_WINDOWS
to determine whether we are executing a Windows build. Take a dependency ontarget.h
because this is minimal. Also teach the s2n-bignum file pro-processing where to findtarget.h
even though I don't think this is strictly necessary; non of the pre-processed files include the header file and everywhere the header file is included will have at leastbase.h
. But do it anyway.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.