Move PQDSA to FIPS module #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
- Coverage 78.67% 78.67% -0.01%
==========================================
Files 598 598
Lines 103329 103347 +18
Branches 14685 14688 +3
==========================================
+ Hits 81298 81308 +10
- Misses 21380 21386 +6
- Partials 651 653 +2 ☔ View full report in Codecov by Sentry. |
crypto/CMakeLists.txt
Outdated
| dilithium/pqdsa.c | ||
| dilithium/p_pqdsa.c | ||
| dilithium/p_pqdsa_asn1.c | ||
| fipsmodule/pqdsa/pqdsa.c |
There was a problem hiding this comment.
these need to be added to bcm.c that defines the code boundary of the fipsmodule. DILITHIUM_SOURCES is not part of the fipsmodule.
andrewhop
approved these changes
Dec 5, 2024
torben-hansen
approved these changes
Dec 6, 2024
justsmth
pushed a commit
to justsmth/aws-lc
that referenced
this pull request
Dec 9, 2024
o fix the CI issues related to ML-DSA we must move code that has dependencies on the fips delocator to the fipsmodule. This PR moves the files accordingly. I haven't moved the entirety of the dilithium directory (including filesml_dsa.c ml_dsa.h or p_pqdsa_test.cc) as there are still in-flight PRs for portions of this code. Once those changes are merged, I plan to create the directory ml_dsa in fipsmodule to store these files.
justsmth
pushed a commit
to justsmth/aws-lc
that referenced
this pull request
Dec 9, 2024
o fix the CI issues related to ML-DSA we must move code that has dependencies on the fips delocator to the fipsmodule. This PR moves the files accordingly. I haven't moved the entirety of the dilithium directory (including filesml_dsa.c ml_dsa.h or p_pqdsa_test.cc) as there are still in-flight PRs for portions of this code. Once those changes are merged, I plan to create the directory ml_dsa in fipsmodule to store these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
To fix the CI issues related to ML-DSA we must move code that has dependencies on the fips delocator to the fipsmodule.
This PR moves the files accordingly. I haven't moved the entirety of the
dilithiumdirectory (including filesml_dsa.cml_dsa.horp_pqdsa_test.cc) as there are still in-flight PRs for portions of this code. Once those changes are merged, I plan to create the directoryml_dsainfipsmoduleto store these files.Callouts:
With ML-DSA now in
bcm.cwe have namespacing issues, thus we change:keygensignverifyofpqdsa/internal.htopqdsa_keygenpqdsa_signpqdsa_verifypqdsa_pkey_methasEVP_PKEY_pqdsa_pkey_methusingDEFINE_METHOD_FUNCTIONand the delocator. We remove all instances ofpqdsa_pkey_meth.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.