Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental null dereference #2046

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

torben-hansen
Copy link
Contributor

@torben-hansen torben-hansen commented Dec 9, 2024

Issues:

P177717548

Description of changes:

Just make sure to prevent null-dereference.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@torben-hansen torben-hansen requested a review from a team as a code owner December 9, 2024 19:19
justsmth
justsmth previously approved these changes Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (2ab1f4d) to head (2592743).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/cipher/cipher.c 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   78.78%   78.76%   -0.02%     
==========================================
  Files         598      598              
  Lines      103654   103676      +22     
  Branches    14736    14743       +7     
==========================================
- Hits        81661    81660       -1     
- Misses      21342    21364      +22     
- Partials      651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WillChilds-Klein WillChilds-Klein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: NULL param test coverage here?

@torben-hansen torben-hansen merged commit 1f5bee2 into aws:main Dec 10, 2024
119 of 124 checks passed
@torben-hansen torben-hansen deleted the P177717548 branch December 10, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants