Delete OpenVPN mainline patch from our integration build #2149
+7
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smittals2
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2149 +/- ##
==========================================
- Coverage 78.96% 78.96% -0.01%
==========================================
Files 611 611
Lines 105514 105514
Branches 14941 14942 +1
==========================================
- Hits 83319 83316 -3
- Misses 21543 21546 +3
Partials 652 652 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Jan 30, 2025
| @@ -41,6 +41,7 @@ function openvpn_build() { | |||
|
|
|||
| OPENSSL_CFLAGS="-I/${AWS_LC_INSTALL_FOLDER}/include" \ | |||
| OPENSSL_LIBS="-L/${AWS_LC_INSTALL_FOLDER}/lib -lssl -lcrypto" \ | |||
| LDFLAGS="-Wl,-rpath=/${AWS_LC_INSTALL_FOLDER}/lib" \ | |||
There was a problem hiding this comment.
Neat, this is a nice fix to avoid having to specify LD_LIBRARY_PATH in a lot of spots.
justsmth
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Delete patch file for mainline build of OpenVPN with AWS-LC now that we have upstreamed support.
OpenVPN/openvpn@aab1f86
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.