Add back deprecated flags for checking whether an instance is managed by NTH #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by NTH We removed these flags in NTH release v1.17.0, but they are still supported for now. The Helm chart should support both in the mean time.
jgournet
approved these changes
Sep 12, 2022
|
LGTM 🚀 It would be nice to add a values.schema.json after the deprecated flag feature becomes supported in Helm |
pdk27
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #682
Description of changes:
We removed these flags in NTH release
v1.17.0, but they are still supported for now. The Helm chart should allow both in the mean time.If the Helm chart includes one of the deprecated flags at install time, NTH will issue a warning, such as the following (source):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.