Don't try to uncordon on startup in Queue Processor mode #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peteroruba you missed this one. |
snay2
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Thanks for the fix!
This will also be important when we remove PodSecurityPolicy (#638), because we want Queue Processor mode to be able to run in a Baseline or Restricted namespace. One thing that would require NTH to run in a Privileged namespace is filesystem access, and this feature tries to read /proc/uptime. That will still be necessary for IMDS mode, but QP mode doesn't need it. Thanks for making that actually true. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The documentation states:
The
.Values.enableScheduledEventDraininghelm configuration key does control one aspect of NTH in Queue Processor mode: whether upon startup it attempts to uncordon the node it is running on.This appears to be a bug. There is no logical reason for NTH to uncordon the node it is running on when not in IMDS mode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.