Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get kernel-devel package for rocky based on installed kernel version #2830

Closed
wants to merge 3 commits into from
Closed

Get kernel-devel package for rocky based on installed kernel version #2830

wants to merge 3 commits into from

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Oct 17, 2024 •
edited
Loading

Description of changes

  • Get kernel-devel package for rocky based on installed kernel version
  • If UpdateOsPackage was enabled, kernel_source_package_version was still set to the old kernel version, so it attempted to download the kernel-devel package for the old kernel version.

Tests

  • Ran the following integ test:
test-suites:
  createami:
    test_createami.py::test_build_image:
      dimensions:
        - regions: ["eu-west-3"]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          schedulers: [ "slurm" ]
          oss: ["rocky8"]

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe hgreebe marked this pull request as ready for review October 17, 2024 15:17
@hgreebe hgreebe requested review from a team as code owners October 17, 2024 15:17
himani2411
himani2411 reviewed Oct 17, 2024
View reviewed changes
cookbooks/aws-parallelcluster-platform/resources/install_packages/install_packages_rocky8.rb

# try to install kernel source for a specific release version
dnf install -y ${package} --releasever #{node['platform_version']}
dnf install -y #{kernel_source_package} --releasever #{node['platform_version']}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be ${package}

@hgreebe hgreebe closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himani2411 himani2411 himani2411 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgreebe @himani2411