Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Build and Release Image: use ecr-public command when targeting ECR public endpoint and standard ecr otherwise. #274

Merged

Conversation

gmarciani
Copy link
Collaborator

Changes

Build and Release Image: use ecr-public command when targeting ECR public endpoint and standard ecr otherwise.
With this change we can reuse the same script used to deploy PCUI official image to deploy a test image in our personal account.

How Has This Been Tested?

  1. Used to deploy PCUI image in personal account
  2. Verified that the variable ECR_COMMAND is populated as expected when targeting public ECR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ECR public endpoint and standard ecr otherwise.
@gmarciani gmarciani requested a review from enrico-usai October 17, 2023 08:54
@gmarciani gmarciani merged commit db24fd7 into aws:main Oct 17, 2023
2 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/ops-improvement-20231017-1 branch October 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants