[Docs] Update attribution doc + improve readme with editing attribution doc #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
reviewed
Feb 15, 2024
| @@ -29,11 +29,14 @@ When working on the project, you may need to add/change a dependency. | |||
| ### Product Dependencies | |||
| To add a product dependency, you should add the dependency with a specified version to the `requirements.in` file, | |||
| and generate `requirements.txt` using [pip-tools](https://github.com/jazzband/pip-tools), | |||
| which is part of dev dependencies (`requirements-dev.txt`) | |||
| which is part of dev dependencies (`requirements-dev.txt`). Then update the attribution document in | |||
There was a problem hiding this comment.
dev dependencies do not need to be in the attribution document as they are not part of the product.
There was a problem hiding this comment.
I updated the readme to be clearer to add update accordingly with changes to requirements.txt
Signed-off-by: Judy Ng <njud@amazon.com>
gmarciani
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge AFTER #311, since this adds licenses from dependencies introduced there
Changes
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.