[BugFix] Explicitly set the policy for ECR private repo so prevent policy removal on stack update impacting Lambda function

[gmarciani]

Description

Explicitly set the policy for ECR private repo so prevent policy removal on stack update impacting Lambda function.
The minimum set of permissions required by Lambda to fetch the code from the repository is:

• ecr:BatchGetImage
• ecr:GetDownloadUrlForLayer

However, Lambda sets the policy with the below extra permissions when the policy is not set m(current behavhoir on stack create):

• ecr:DeleteRepositoryPolicy
• ecr:GetRepositoryPolicy
• ecr:SetRepositoryPolicy

So we decided to go with the permissions currently set by Lambda to prevent impacts.
We will restrict the permissions once Lambda will confirm that they are enough.

How Has This Been Tested?

Deployed in personal account and verified that:

1. ECR repo policy is retained across stack updates
2. Lambda is fully functional before and after stack updates

References

1. https://docs.aws.amazon.com/lambda/latest/dg/images-create.html

PR Quality Checklist

• I added tests to new or existing code
• I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
• I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
• I made sure that any GitHub issue solved by this PR is correctly linked
• I checked that infrastructure/update_infrastructure.sh runs without any error
• I checked that npm run build builds without any error
• I checked that clusters are listed correctly
• I checked that a new cluster can be created (config is produced and dry run passes)
• I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.