Skip to content

Commit

Permalink
[Test] Make test_job_level_scaling head node instance type architectu…
Browse files Browse the repository at this point in the history
…re agnostic

The test is run both with x86 and ARM

Signed-off-by: Hanwen <hanwenli@amazon.com>
  • Loading branch information
hanwen-cluster committed Dec 23, 2024
1 parent 925153c commit fa7bba5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion tests/integration-tests/tests/scaling/test_scaling.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from tests.schedulers.test_slurm import _assert_job_state


@pytest.mark.usefixtures("os", "instance")
@pytest.mark.usefixtures("os")
@pytest.mark.parametrize(
"scaling_strategy, scaling_behaviour_by_capacity",
[
Expand Down Expand Up @@ -185,6 +185,7 @@
)
def test_job_level_scaling(
region,
instance,
pcluster_config_reader,
clusters_factory,
scheduler_commands_factory,
Expand All @@ -197,10 +198,13 @@ def test_job_level_scaling(
# with multiple compute resources. (2 queues with 2 compute resources + 46 queues with 1 compute resource)
no_of_queues = 46

head_node_instance_type = instance.replace(".xlarge", ".2xlarge")

cluster_config = pcluster_config_reader(
scaledown_idletime=scaledown_idletime,
scaling_strategy=scaling_strategy,
no_of_queues=no_of_queues,
head_node_instance_type=head_node_instance_type,
)
cluster = clusters_factory(cluster_config)
remote_command_executor = RemoteCommandExecutor(cluster)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Image:
Os: {{ os }}
HeadNode:
InstanceType: "c5.2xlarge"
InstanceType: {{ head_node_instance_type }}
Networking:
SubnetId: {{ public_subnet_id }}
Ssh:
Expand Down

0 comments on commit fa7bba5

Please sign in to comment.