Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Add bad URL suffix pull request check #6575

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

hehe7318
Copy link
Contributor

Description of changes

  • Add bad URL suffix pull request check

Tests

  • I added some test URLs(e.g. # This is a test URL: https://example.c2s.ic.gov) in several files and create a PR. It can correctly detect.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Nov 25, 2024
@hehe7318 hehe7318 requested review from a team as code owners November 25, 2024 21:00
.github/workflows/ci.yml Outdated Show resolved Hide resolved
util/detect_bad_urls.sh Outdated Show resolved Hide resolved
@hehe7318 hehe7318 added skip-bad-url-suffix-check Skip the checks regarding the bad URL suffix and removed skip-bad-url-suffix-check Skip the checks regarding the bad URL suffix labels Nov 27, 2024
@hehe7318 hehe7318 enabled auto-merge (squash) November 27, 2024 16:17
@hehe7318 hehe7318 merged commit 255e1af into aws:develop Nov 27, 2024
24 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster that referenced this pull request Dec 3, 2024
* Add bad URL suffix pull request check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants