Skip to content

Commit

Permalink
chore(nx-monorepo): remove redundant subproject npmrc files (#385)
Browse files Browse the repository at this point in the history
Fix #376

Co-authored-by: Adrian Dimech <51220968+agdimech@users.noreply.github.com>
  • Loading branch information
cogwirrel and agdimech authored May 3, 2023
1 parent d1970a0 commit 8274f0a
Show file tree
Hide file tree
Showing 29 changed files with 7 additions and 70 deletions.
3 changes: 0 additions & 3 deletions packages/aws-arch/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/aws-arch/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/cdk-graph-plugin-diagram/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/cdk-graph-plugin-diagram/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/cdk-graph/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/cdk-graph/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/cloudscape-react-ts-website/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/cloudscape-react-ts-website/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/cloudscape-react-ts-website/samples/.npmrc

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/identity/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/identity/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/nx-monorepo/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/nx-monorepo/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/nx-monorepo/src/nx-monorepo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,13 @@ export class NxMonorepoProject extends TypeScriptProject {
}
});
}

// Remove any subproject .npmrc files since only the root one matters
this.subProjects.forEach((subProject) => {
if (isNodeProject(subProject)) {
subProject.tryRemoveFile(".npmrc");
}
});
}

/**
Expand Down
17 changes: 0 additions & 17 deletions packages/nx-monorepo/test/__snapshots__/nx-monorepo.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/open-api-gateway/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/open-api-gateway/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/pdk-nag/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/pdk-nag/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/pipeline/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/pipeline/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/static-website/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/static-website/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/type-safe-api/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/type-safe-api/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions public/docs/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion public/docs/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion samples/pipeline/typescript/.projen/files.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8274f0a

Please sign in to comment.