feat(type-safe-api): replace openapi-generator for typescript rest api code generation #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0736ec3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…i code generation This change replaces the java openapi-generator CLI tool with our own code generation tool, which produces equivalent code. This removes the dependency on Java for the TypeScript REST API projects, as well as improving the speed of code generation by avoiding package installation steps and the multiple passes of openapi codegen used to work around limitations of the tool. Note that this change fixes #789, which means that those hitting the edge case described in the issue may experience a breaking change. Generated code packages now covered by the new codegen: - typescript runtime - typescript infrastructure - typescript handlers - typescript hooks
cogwirrel
force-pushed
the
feat/no-openapi-generator
branch
from
a596e4b
to
0736ec3
Compare
agdimech
reviewed
Sep 30, 2024
...pe-safe-api/scripts/type-safe-api/generators/typescript-cdk-infrastructure/templates/api.ejs
Show resolved
Hide resolved
...ages/type-safe-api/src/project/codegen/runtime/generated-typescript-async-runtime-project.ts
Show resolved
Hide resolved
agdimech
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the java openapi-generator CLI tool with our own code generation tool, which produces equivalent code. This removes the dependency on Java for the TypeScript REST API projects, as well as improving the speed of code generation by avoiding package installation steps and the multiple passes of openapi codegen used to work around limitations of the tool.
Note that this change fixes #789, which means that those hitting the edge case described in the issue may experience a breaking change.