Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type-safe-api): generate models for inline request body schemas #873

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(type-safe-api): generate models for inline request body schemas #873

merged 1 commit into from
Oct 25, 2024

Commits on Oct 24, 2024

  1. fix(type-safe-api): generate models for inline request body schemas 

    Inline request body schemas were typed as `any` and no model was generated for them.

Address this by hoisting inline request schemas in the same way we do for responses.

Note that OpenAPI generator named these hoisted inline request models `<OperationID>Request` which
also clashes with the overall operation request model - and resolved it by appending `Operation` to
the Operation ID (see #789).

We deviate from OpenAPI generator behaviour to avoid this issue recurring by naming the type
`<OperationID>RequestContent`.
    @cogwirrel
    cogwirrel committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1df132d View commit details
    Browse the repository at this point in the history