Skip to content

Commit

Permalink
fix: update NodeJS version in lambda layer (#459)
Browse files Browse the repository at this point in the history
  • Loading branch information
kozlove-aws authored and jusiskin committed Jun 18, 2021
1 parent acf0b8e commit 5226b9a
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [12.x, 14.x, 16.x]

steps:
- uses: actions/checkout@v2.3.4
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ and let us know if it's not up-to-date (even better, submit a PR with your corr
The RFDK is written in Typescript and converted, using [jsii](https://github.com/aws/jsii), into Python. Thus, the
minimal development environment must include:

- Node.js >= 10.21.0
- Node.js >= 12.18.3
- docker >= 18

We also recommend developing on a Linux system.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ It offers high-level object-oriented abstractions to define render farm infrastr
using the power of Python and Typescript.

The RFDK is available in:
- Javascript, Typescript ([Node.js >= 10.21.0](https://nodejs.org/download/release/latest-v10.x/))
- Javascript, Typescript ([Node.js >= 12.18.3](https://nodejs.org/download/release/latest-v12.x/))
- We recommend using an [Active LTS Release](https://nodejs.org/en/about/releases/)
- Python ([Python >= 3.6](https://www.python.org/downloads/))

Expand Down
2 changes: 1 addition & 1 deletion integ/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,6 @@
"aws-sdk": "^2.928.0"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
"node": ">= 12.18.3 <13 || >=13.7.0"
}
}
4 changes: 2 additions & 2 deletions lambda-layers/layers/openssl-al2/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM amazonlinux
FROM public.ecr.aws/amazonlinux/amazonlinux:2

RUN yum install -y openssl zip
RUN mkdir -p /tmp/layer
Expand All @@ -13,4 +13,4 @@ CMD cd /tmp/layer && \
rm -rf bin lib && \
echo "OpenSSL $(openssl version | cut -d ' ' -f 2) for Amazon Linux 2" > description.txt && \
echo "OpenSSL ( https://spdx.org/licenses/OpenSSL.html#licenseText )" > license.txt && \
echo "nodejs10.x nodejs12.x" > runtimes.txt
echo "nodejs12.x nodejs14.x" > runtimes.txt
2 changes: 1 addition & 1 deletion lambda-layers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"watch": "tsc -w"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
"node": ">= 12.18.3 <13 || >=13.7.0"
},
"stability": "stable",
"maturity": "stable",
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-rfdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@
"constructs": "^3.3.69"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
"node": ">= 12.18.3 <13 || >=13.7.0"
},
"stability": "stable",
"maturity": "stable"
Expand Down
2 changes: 1 addition & 1 deletion tools/cdk-build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
],
"homepage": "https://github.com/aws/aws-cdk",
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
"node": ">= 12.18.3 <13 || >=13.7.0"
},
"pkglint": {
"exclude": [
Expand Down
8 changes: 4 additions & 4 deletions tools/pkglint/lib/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -376,11 +376,11 @@ export class NodeCompatibility extends ValidationRule {

public validate(pkg: PackageJson): void {
const atTypesNode = pkg.getDevDependency('@types/node');
if (atTypesNode && !atTypesNode.startsWith('^10.')) {
if (atTypesNode && !atTypesNode.startsWith('^12.')) {
pkg.report({
ruleName: this.name,
message: `packages must support node version 10 and up, but ${atTypesNode} is declared`,
fix: () => pkg.addDevDependency('@types/node', '^10.17.5'),
message: `packages must support node version 12 and up, but ${atTypesNode} is declared`,
fix: () => pkg.addDevDependency('@types/node', '^12.18.3'),
});
}
}
Expand Down Expand Up @@ -629,7 +629,7 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
public readonly name = 'package-info/engines';

public validate(pkg: PackageJson): void {
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
expectJSON(this.name, pkg, 'engines.node', '>= 12.18.3 <13 || >=13.7.0');
}
}

Expand Down

0 comments on commit 5226b9a

Please sign in to comment.