Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests failing during start-up #164

Closed
horsmand opened this issue Oct 9, 2020 · 0 comments · Fixed by #166
Closed

Integration tests failing during start-up #164

horsmand opened this issue Oct 9, 2020 · 0 comments · Fixed by #166
Labels
bug This issue is a bug.

Comments

@horsmand
Copy link
Contributor

horsmand commented Oct 9, 2020

The integration tests are unable to run due to a failure in our rfdk-integ-e2e.sh script.

Reproduction Steps

Fill in integ/test-config.sh without using any pre-component hooks and then run yarn run e2e from the integ directory.

Error Log

./scripts/bash/rfdk-integ-e2e.sh: line 77: PRE_COMPONENT_HOOK: unbound variable

Environment

This failure is happening in a bash script in our integration test directory. This is happening trying to run the integration tests on Linux using our current mainline branch.

Solution

if [ -n "PRE_COMPONENT_HOOK" ]

Should be written as:

if [ ! -z "${PRE_COMPONENT_HOOK+x}" ]

This is 🐛 Bug Report
@horsmand horsmand added the bug This issue is a bug. label Oct 9, 2020
horsmand referenced this issue in horsmand/aws-rfdk Oct 9, 2020
@horsmand
fix(integ): Fixed rfdk-integ-e2e.sh
9c9e31d 
Fixes a bug where we were referencing the environment variable
PRE_COMPONENT_HOOK in a way that would fail if it were unassigned.

Fixes #164
@horsmand horsmand mentioned this issue Oct 9, 2020
Merged
jusiskin pushed a commit that referenced this issue Oct 9, 2020
@horsmand
fix(integ): fix when PRE_COMPONENT_HOOK is undefined (#166)
b4bfd4e 
Fixes a bug where we were referencing the environment variable
PRE_COMPONENT_HOOK in a way that would fail if it were unassigned.

Fixes #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(integ): fix when PRE_COMPONENT_HOOK is undefined horsmand/aws-rfdk
1 participant
@horsmand