Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version bump script to add CDK version to changelog #200

Closed
1 of 2 tasks
horsmand opened this issue Oct 30, 2020 · 0 comments
Closed
1 of 2 tasks

Update version bump script to add CDK version to changelog #200

horsmand opened this issue Oct 30, 2020 · 0 comments
Labels
feature-request A feature should be added or improved.

Comments

@horsmand
Copy link
Contributor

Running the version bump script should update the changelog to include a section that displays the version of CDK that the new version of RFDK is depending on.

Use Case

Currently the process of adding the version of CDK is done manually after the bump script is ran. We would like to automate this process and combine it into the bump script.

Proposed Solution

This can be accomplished by pulling the CDK version from the package.json using node and then using sed in bash.sh to find the correct spot in the changelog and add in the new section.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@horsmand horsmand added the feature-request A feature should be added or improved. label Oct 30, 2020
horsmand referenced this issue in horsmand/aws-rfdk Oct 30, 2020
@horsmand
chore: updates to the bump script
4725c39 
Fixes #173 and #200

* Added automation for bumping the RFDK version in the python example
* Added automation for adding a section to the changelog that lists the
version of CDK that this version of RFDK depends on
horsmand referenced this issue in horsmand/aws-rfdk Oct 30, 2020
@horsmand
chore: updates to the bump script
a3a9dec 
Fixes #173 and #200

* Added automation for bumping the RFDK version in the python example
* Added automation for adding a section to the changelog that lists the
version of CDK that this version of RFDK depends on
@horsmand horsmand mentioned this issue Oct 30, 2020
Merged
ddneilson pushed a commit that referenced this issue Nov 4, 2020
@horsmand
chore: updates to the bump script (#201)
0c1b37c 
* chore: updates to the bump script

Fixes #173 and #200

* Added automation for bumping the RFDK version in the python example
* Added automation for adding a section to the changelog that lists the
version of CDK that this version of RFDK depends on

* Addressed PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@horsmand