-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bin): Add simpler way to invoke stage-deadline #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the input handling looks good. I think there's just one minor fix to be made to the usage help output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds a new way to call the
stage-deadline
script. The current URIs are awkward to use, so this change introduces a positional argument,<deadline_release_version>
that fills in the conventional Deadline release installer & docker URIs with the given release version number. Loosely copied from the command's new usage help:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license