Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bin): Add simpler way to invoke stage-deadline #90

Merged
merged 5 commits into from
Sep 21, 2020
Merged

feat(bin): Add simpler way to invoke stage-deadline #90

merged 5 commits into from
Sep 21, 2020

Conversation

ddneilson
Copy link
Contributor

@ddneilson ddneilson commented Aug 27, 2020 •
edited by jusiskin
Loading

This adds a new way to call the stage-deadline script. The current URIs are awkward to use, so this change introduces a positional argument, <deadline_release_version> that fills in the conventional Deadline release installer & docker URIs with the given release version number. Loosely copied from the command's new usage help:

Usage: stage-deadline [--output <output_dir>] [--verbose]
                      <deadline_release_version>

Arguments:
    <deadline_release_version>
        Specifies the official release of Deadline that should be staged. This must be of the form a.b.c.d.
        Both '-d' or '-c' arguments will be ignored if provided with this value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ddneilson ddneilson requested a review from jusiskin August 27, 2020 19:41
@ddneilson ddneilson added the contribution/core This is a PR that came from AWS. label Aug 27, 2020
@yashda yashda requested review from grbartel and horsmand September 18, 2020 14:36
jusiskin
jusiskin requested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the input handling looks good. I think there's just one minor fix to be made to the usage help output.

packages/aws-rfdk/bin/stage-deadline.ts Outdated Show resolved Hide resolved
@yashda yashda requested a review from jusiskin September 21, 2020 14:02
jusiskin
jusiskin approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - approved!

jericht
jericht approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jusiskin jusiskin changed the title feat(bin): Add release option to stage-deadline feat(bin): Add simpler way to invoke stage-deadline Sep 21, 2020
@jusiskin jusiskin merged commit cb68992 into aws:mainline Sep 21, 2020
@ddneilson ddneilson deleted the stage_deadline_release branch March 17, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashda yashda yashda left review comments

@jericht jericht jericht approved these changes

@jusiskin jusiskin jusiskin approved these changes

@grbartel grbartel Awaiting requested review from grbartel

@horsmand horsmand Awaiting requested review from horsmand

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ddneilson @grbartel @horsmand @jusiskin @yashda @jericht