Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix mismatched cdk core module version in ts example #122

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

jusiskin
Copy link
Contributor

@jusiskin jusiskin commented Sep 9, 2020

Problem

The TypeScript example app in examples/deadline/All-In-AWS-Infrastructure-Basic/ts had specified a mismatched version of @aws-cdk/core in its dependencies. When trying to build the example with:

yarn run build

The following errors like the following were being output:

lib/compute-tier.ts:77:44 - error TS2345: Argument of type 'this' is not assignable to parameter of type 'Construct'.
  Type 'ComputeTier' is not assignable to type 'Construct'.
    Types of property 'node' are incompatible.
      Type 'import("/my/checkout/rfdk-example/examples/deadline/All-In-AWS-Infrastructure-Basic/ts/node_modules/@aws-cdk/core/lib/construct-compat").ConstructNode' is not assignable to type 'import("/my/checkout/rfdk-example/node_modules/@aws-cdk/core/lib/construct-compat").ConstructNode'.

Change

Correcting the dependency version from 1.57.0 → 1.61.1 resolved the errors.

Testing

Followed the instructions in the example's README.md file and successfully deployed the example app.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin requested a review from jericht September 9, 2020 15:24
@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label Sep 9, 2020
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh!

Copy link
Contributor

@yashda yashda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks Josh!

@jusiskin jusiskin merged commit 20db251 into aws:mainline Sep 18, 2020
@jusiskin jusiskin deleted the fix_ts_example_cdk_version branch September 18, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants