chore(deadline): clean up UsageBasedLicensing construct and tests #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There were a few minor issues with the
UsageBasedLicensing
construct that needed improvement:UsageBasedLicensing
construct needed to supply at least one of thememoryReservationMib
ormemoryLimitMib
props. The intention was that the containers would grow to use available memory on the host container instance.docker
which is not intuitive when looking up the logs in CloudWatchSolution
memoryReservationMib
of 1024 MiB is used and the containers will grow to use available memory from the hoistLicenseForwarder
Testing
UsageBasedLicensing
construct end-to-end successfullyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license