-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deadline): add ConfigureSpotEventPlugin and SpotEventPluginFleet constructs #279
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c1e9c40
feat(deadline): adding dealine client to connect to rcs
ryyakobe 14b6812
First draft of SEP Spot Fleet that builds
ryyakobe 6e64c8e
creating spot fleet configuration
ryyakobe bf2fbfe
simplified tagging
ryyakobe 717ed83
draft of custom resource
ryyakobe 9dd706d
cdk deploy works but sfr is empty
ryyakobe 0b9a288
working rendering without tls, but failing handshake with tls
ryyakobe eedda5f
feat(deadline): add SEPConfigurationSetup construct
ryyakobe b4711ec
chore(deadline): refinements
jusiskin ae92074
chore(deadline): making fleet role optional in sep configuration
ryyakobe 3ecf241
chore(deadline) adding type safety to spot event plugin configuration
ryyakobe d4ff73b
chore(deadline): addressing codereview comments
ryyakobe 4dae8ff
chore(deadline): adding validations to sep configs
ryyakobe d85d13f
chore(deadline): adding validations to the spot fleet request props
ryyakobe 2aee5a2
chore(deadline): unit tests for spot fleet
ryyakobe 9f4d1f8
chore(deadline): increasing test coverage
ryyakobe 6ff4fd7
fix(deadline): destroying configure spot event plugin in a wrong order
ryyakobe dfc67a2
feat(deadline): adding construct that waits for ecs service
ryyakobe c16e397
chore(deadline:) getting certificate from the redner queue
ryyakobe 4fbc626
chore(deadline): minor code review comments
ryyakobe 3db13c4
chore(deadline): validating instance role stack
ryyakobe 0f3d59a
chore(deadline): adding documentation for disabling house cleaning
ryyakobe eb3bb4a
chore(deadline): adding public to properties
ryyakobe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
examples/deadline/All-In-AWS-Infrastructure-SEP/python/package/config.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from typing import ( | ||
List, | ||
Mapping, | ||
Optional, | ||
) | ||
|
||
class AppConfig: | ||
""" | ||
Configuration values for the sample app. | ||
|
||
TODO: Fill these in with your own values. | ||
""" | ||
def __init__(self): | ||
# A map of regions to Deadline Client Linux AMIs. As an example, the Linux Deadline 10.1.12.1 AMI ID | ||
# from us-west-2 is filled in. It can be used as-is, added to, or replaced. Ideally the version here | ||
# should match the one used for staging the render queue and usage based licensing recipes. | ||
self.deadline_client_linux_ami_map: Mapping[str, str] = {'us-west-2': 'ami-039f0c1faba28b015'} | ||
|
||
|
||
config: AppConfig = AppConfig() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10.1.12 is the minimum version required for this change to work? I'm not complaining, I just want to be sure. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes