fix(core): increase timeout for AcmCertificateImporter #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
commented
Jun 8, 2021
yarn.lock
Outdated
| @@ -507,6 +507,13 @@ | |||
| "@aws-cdk/region-info" "1.106.1" | |||
| constructs "^3.3.69" | |||
|
|
|||
| "@aws-cdk/aws-imagebuilder@1.106.1": | |||
There was a problem hiding this comment.
Looks like the change to add the imagebuilder example didn't include an update to the yarn.lock
ddneilson
commented
Jun 8, 2021
| // component of backoff fixed to ensure minimum total wait time on | ||
| // slow targets. | ||
| const base = Math.pow(2, attempt); | ||
| await defaultSleep(Math.random() * base * 50 + base * 150); | ||
| const backoffDelay = Math.floor(Math.random() * base * 200 + base * 1000 - 100); |
There was a problem hiding this comment.
I've increased the delay from a base of 200ms. I figure we're waiting for the ACM service here to update the certificate; possibly also waiting for the ALB to signal that it's no longer using it as well.
So, rather than waiting (max): 0.2s, 0.35s, 0.65s, 1.250s, 2.45s, 4.85s, 9.65s, 19.25s (which won't finish due to 30s lambda timeout)
It might make more sense to wait longer, but cap out the delay (max) 1.1s, 2.1s, 4.1s, 8.1s, 16.1s, 30s, 30s, ....
ddneilson
force-pushed
the
fix_issue409
branch
2 times, most recently
from
3f03beb
to
faa3ebf
Compare
jusiskin
previously approved these changes
Jun 14, 2021
jericht
previously approved these changes
Jun 16, 2021
yashda
approved these changes
Jun 17, 2021
jusiskin
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #463
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license