Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add resolutions for trim-newlines and meow #478

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

jericht
Copy link
Contributor

@jericht jericht commented Jun 18, 2021

Notes

Testing

  • Usages of lerna are covered by our CI runners
  • Ran bump.sh to verify standard-version still works correctly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added dependencies This issue is a problem in a dependency. contribution/core This is a PR that came from AWS. labels Jun 18, 2021
@jericht jericht force-pushed the jericht/update_trim_newlines branch from d487065 to 69805fc Compare June 18, 2021 18:32
jusiskin
jusiskin previously approved these changes Jun 18, 2021
yashda
yashda previously approved these changes Jun 18, 2021
Copy link
Contributor

@yashda yashda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! Thanks for putting up the PR.

@jericht jericht dismissed stale reviews from yashda and jusiskin via 47c6939 June 18, 2021 21:52
@jericht jericht force-pushed the jericht/update_trim_newlines branch from 69805fc to 47c6939 Compare June 18, 2021 21:52
Copy link
Contributor

@yashda yashda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@jusiskin jusiskin merged commit 7168b1f into aws:mainline Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants