Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a ToC to and reorder the Deadline README #64

Merged
merged 2 commits into from
Aug 17, 2020
Merged

chore: Add a ToC to and reorder the Deadline README #64

merged 2 commits into from
Aug 17, 2020

Conversation

ddneilson
Copy link
Contributor

Just adding a table of contents to the Deadline README. Also reordering the sections to alphabetical so that it matches the core README.

No text was altered.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jericht
jericht previously approved these changes Aug 17, 2020
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one broken link and then lets merge this!

- [Configuring Deadline Client Connections](#configuring-deadline-client-connections)
- [Stage](#stage)
- [Staging Docker Recipes](#staging-docker-recipes)
- [Usage Based Licensing](#usage-based-licensing-(ubl))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link doesn't work in GitHub. The anchor ID auto-generated by GitHub's markdown converter resolves to #usage-based-licensing-ubl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, weird. It worked in a local markdown renderer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest revision. @jusiskin @jericht

@jusiskin jusiskin merged commit dd252e6 into aws:mainline Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants