feat(all): migrate to CDKv2 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddneilson
commented
Jul 27, 2022
| })); | ||
| }); | ||
|
|
||
| test('creates an asset', () => { |
There was a problem hiding this comment.
Note: This test is not possible with the under-the-hood changes introduced in CDKv2. Fortunately, this is tested, in a way, by the tests that look at UserData; the CDK now generates the file sha256 before synthesis, so file hashes are directly embedded into UserData in both the rendered stack and when directly rendering the UserData string from the contruct.
kozlove-aws
reviewed
Jul 27, 2022
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/config.py
Outdated
Show resolved
Hide resolved
examples/deadline/All-In-AWS-Infrastructure-Basic/python/package/lib/storage_tier.py
Show resolved
Hide resolved
ddneilson
force-pushed
the
migrate_cdk_v2
branch
from
3158b4e to
fd2ee20
Compare
jericht
previously approved these changes
Jul 28, 2022
Comment on lines
342
to
343
| //const res = Template.fromStack(stack).findResources('AWS::IAM::Policy', Match.anyValue); | ||
| //expect(res).toBe({ foo: 'bar' }); |
There was a problem hiding this comment.
Drat. Will fix. Thanks!
| Tags, | ||
| } from '@aws-cdk/core'; | ||
| } from 'aws-cdk-lib/aws-iam'; | ||
| //import { ArtifactMetadataEntryType } from '@aws-cdk/cloud-assembly-schema'; |
There was a problem hiding this comment.
Drat. Will fix. Thanks!
* Migrates the RFDK library, examples, and integration tests to CDKv2. BREAKING CHANGE: This change migrates the RFDK to be based on CDK v2. All apps that use the RFDK will have to be migrated to CDKv2 as well. To update your app, follow the CDK's migration guide at: https://docs.aws.amazon.com/cdk/v2/guide/migrating-v2.html
ddneilson
force-pushed
the
migrate_cdk_v2
branch
from
fd2ee20 to
db96f35
Compare
kozlove-aws
approved these changes
Jul 28, 2022
jericht
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This change migrates the RFDK to be based on CDK v2.
All apps that use the RFDK will have to be migrated to CDKv2 as well.
To update your app, follow the CDK's migration guide at:
https://docs.aws.amazon.com/cdk/v2/guide/migrating-v2.html
Some notes:
@aws-cdk/assertsmodule that we were using for unit tests and replaced it withaws-cdk-lib/assertions. This was a major change. Syntax and functionality changed. The CDK team provides a migration guide (here: https://github.com/aws/aws-cdk/blob/v1-main/packages/@aws-cdk/assertions/MIGRATING.md ) that includes a migration script; the script got about 70% of the way, and the rest had to be done manually. The biggest change was that once you've asserted properties of a stack/app in a test then the state of the stack is baked-in at that time. So, you cannot, say, assert a property, then add something to the stack, and then assert a new property -- the second assertion will fail as it will be asserting against the stack pre-addition; this change required retooling some unit tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license