Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deadline): Fix Python bindings of ThinkboxDockerImages #880

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ddneilson
Copy link
Contributor

Fixes: #818


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

leongdl
leongdl previously approved these changes Oct 28, 2022
@jusiskin jusiskin added bug This issue is a bug. documentation This is a problem with documentation. contribution/core This is a PR that came from AWS. labels Oct 28, 2022
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just recall there's also the example code inpackages/aws-rfdk/lib/deadline/README.md. Should we update that too?

@jusiskin
Copy link
Contributor

We should also update the example code in the developer guide as a follow-up. That should be coordinated to coincide with the release of this code.

@leongdl leongdl self-requested a review October 28, 2022 20:21
@ddneilson ddneilson merged commit b283e67 into aws:mainline Oct 28, 2022
@ddneilson ddneilson deleted the ddneilson/fix_examples branch December 14, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThinkboxDockerImages type is not compatible with RenderQueueProps
3 participants