Fix node debugger protocol #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As some background for this change, inspector does not report end of execution (in Node 6.10) so the debugger never knows when to disconnect. This PR was made and merged for Node 7+ but never backported to Node 6.10. Because of this, IDEs can't know when the debugger should detach if they're using inspector for Node6.x or below. |
|
See also the official Node docs on debugging that mentions:
|
|
Lastly, it's worth noting that the previous change to inspector was prompted by a bug in VSCode. That bug has since been fixed (see comment from previous PR). |
sanathkr
approved these changes
Apr 10, 2018
qingchm
pushed a commit
to qingchm/aws-sam-cli
that referenced
this pull request
Sep 17, 2021
* Added Locking to Layer Building * Fixed LockChain Exception * Added Comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Pertains to this comment made on this PR.
Description of changes:
Changes the run command for Node.js version 6.10 to use the legacy debugger (as it previously did) instead of the inspector debugger. Includes directions in the README for when to use legacy and when to use inspector in your launch configuration in VSCode.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.