Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lambda streaming support for remote invoke #5307
feat: add lambda streaming support for remote invoke #5307
Changes from all commits
7da252f
1d98a0a
1fbbfd8
fac2a92
c97c6d5
73af887
bd05b4c
c51e08c
d8c11f6
9991b9c
a27b0fb
5f739ef
d99d0ee
d3bbcbc
976794f
da342d3
a375ab0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably out of scope of this PR - I'm not a big fan of using
Any
for annotation. Can we look into using https://youtype.github.io/boto3_stubs_docs/mypy_boto3_lambda/#lambdaclient?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried setting its type to
LambdaClient
but then I've faced following issues;LambdaClient
then I can't keep using decomposing a dictionary to use as parameters. I need to extract them one by one to use in function call since there is no type definition for the function parameters.Dict[Any, Any]
even though it should cover wider.We will have a refactoring task next week, we will try to re-introduce typing there.