Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Use correct build and cwd folder when building nested stacks #6100

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Oct 17, 2023

Which issue(s) does this change fix?

None.

Why is this change necessary?

The build and working directory was not being set correctly in this tests after the base class optimization, causing the symlinked template's resources to be resolved incorrectly.

How does it address the issue?

Sets the base build directory and working directory to get the symlink to resolve correctly.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review October 17, 2023 23:49
@lucashuy lucashuy requested a review from a team as a code owner October 17, 2023 23:49
@lucashuy lucashuy requested review from mndeveci and jfuss October 17, 2023 23:49
@lucashuy lucashuy added this pull request to the merge queue Oct 18, 2023
Merged via the queue into aws:develop with commit 2d28d3a Oct 18, 2023
78 checks passed
moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants