-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync timestamp #6575
Sync timestamp #6575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing @anupkashyap, changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, looks good to me! @hnnasit there might be some integration tests which validates the output, we might need to update them.
Which issue(s) does this change fix?
#5267
Why is this change necessary?
This change addresses the request to add timestamp to the the sync file when watching which would make it easier to find out when the last sync was completed
How does it address the issue?
Adds a formatted timestamp in front of the log message
What side effects does this change have?
None
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.