Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync timestamp #6575

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Sync timestamp #6575

merged 8 commits into from
Feb 6, 2024

Conversation

anupkashyap
Copy link
Contributor

@anupkashyap anupkashyap commented Jan 18, 2024

Which issue(s) does this change fix?

#5267

Why is this change necessary?

This change addresses the request to add timestamp to the the sync file when watching which would make it easier to find out when the last sync was completed

How does it address the issue?

Adds a formatted timestamp in front of the log message

What side effects does this change have?

None

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@anupkashyap anupkashyap requested a review from a team as a code owner January 18, 2024 17:10
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jan 18, 2024
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @anupkashyap, changes LGTM!

@hnnasit hnnasit removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Jan 19, 2024
Copy link
Contributor

@mndeveci mndeveci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, looks good to me! @hnnasit there might be some integration tests which validates the output, we might need to update them.

@mildaniel mildaniel enabled auto-merge February 6, 2024 18:51
@mildaniel mildaniel added this pull request to the merge queue Feb 6, 2024
Merged via the queue into aws:develop with commit 49c5325 Feb 6, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants