Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise UserException when an invalid runtime is specified #6701

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Feb 15, 2024

Which issue(s) does this change fix?

#6558

Why is this change necessary?

Previously, a Python ValueError was raised when an invalid runtime is specified in the template file a function. This causes a stack trace to be displayed, and the wrong error code to be emitted to customers.

How does it address the issue?

Raises a new custom UserException error instead.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review February 16, 2024 00:18
@lucashuy lucashuy requested a review from a team as a code owner February 16, 2024 00:18
@mildaniel mildaniel added this pull request to the merge queue Feb 16, 2024
Merged via the queue into aws:develop with commit 0391162 Feb 16, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants