chore: bump python pysintaller versions #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnnasit
reviewed
Sep 9, 2024
| @@ -12,7 +12,7 @@ if [ "$python_library_zip_filename" = "" ]; then | |||
| fi | |||
|
|
|||
| if [ "$python_version" = "" ]; then | |||
| python_version="3.11.8"; | |||
| python_version="3.11.10"; | |||
There was a problem hiding this comment.
Should we also bump the python versions in GH actions?
There was a problem hiding this comment.
Looks like we don't pin them, so should be alright.
There was a problem hiding this comment.
I thought for GH actions, you can't specify the minor version, just the major version, hopefully it will just use the latest
hnnasit
approved these changes
Sep 9, 2024
lucashuy
approved these changes
Sep 9, 2024
mndeveci
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Because of CVE from https://www.cve.org/CVERecord?id=CVE-2024-45490, we need to bump python versions of pyinstaller to latest version
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.