Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove URI::URLEncodePath #2113

Closed
wants to merge 1 commit into from
Closed

remove URI::URLEncodePath #2113

wants to merge 1 commit into from

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Sep 27, 2022

Issue #, if available:
#2103

Description of changes:
remove URI::URLEncodePath

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmklix jmklix closed this Oct 5, 2022
@jmklix jmklix deleted the issue_2103 branch October 5, 2022 23:49
@jmklix jmklix restored the issue_2103 branch October 18, 2022 17:42
@jmklix jmklix reopened this Oct 18, 2022
@jmklix jmklix mentioned this pull request Oct 18, 2022
Closed
@jmklix
Copy link
Member Author

jmklix commented Nov 4, 2022

add if s3 check to code-gen

@jmklix jmklix added the pr/work-in-progress This PR is a draft and needs further work. label Nov 18, 2022
@yashNaN yashNaN mentioned this pull request Jun 30, 2023
Merged
@jmklix jmklix closed this Aug 23, 2023
@jmklix jmklix deleted the issue_2103 branch August 23, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmklix