Skip to content

Commit

Permalink
backfill @required on imagebuilder#LaunchTemplateConfiguration.SetDef…
Browse files Browse the repository at this point in the history
…aultVersion
  • Loading branch information
lucix-aws committed Oct 15, 2024
1 parent 8ed647a commit 8fcb670
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
8 changes: 8 additions & 0 deletions .changelog/139b04a8d6124cb29dfb9e66f9f70386.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "139b04a8-d612-4cb2-9dfb-9e66f9f70386",
"type": "bugfix",
"description": "**BREAKING CHANGE**: The value of LaunchTemplateConfiguration.SetDefaultVersion will now always be serialized in requests to the service, regardless of whether a value was set by the caller. Before this change, the value was not serialized if set to false. This behavior was broken because the service team had marked this value as being false by default, but did not actually do so, making it functionally impossible for users to set a false value for this field. **If you were not explicitly setting a value for this field before, the client will now send false by default.**",
"modules": [
"service/imagebuilder"
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ public class BackfillRequiredTrait implements GoIntegration {
private static final Map<ShapeId, Set<ShapeId>> toBackfill = Map.ofEntries(
serviceToShapeIds("com.amazonaws.sqs#AmazonSQS",
// https://github.com/aws/aws-sdk/issues/527
"com.amazonaws.sqs#ChangeMessageVisibilityBatchRequestEntry$VisibilityTimeout")
"com.amazonaws.sqs#ChangeMessageVisibilityBatchRequestEntry$VisibilityTimeout"),
serviceToShapeIds("com.amazonaws.imagebuilder#imagebuilder",
// https://github.com/aws/aws-sdk-go-v2/issues/2734
// V1479153907
"com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion")
);

private boolean mustPreprocess(ShapeId service) {
Expand Down Expand Up @@ -54,4 +58,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
ShapeId.from(serviceId),
Arrays.stream(shapeIds).map(ShapeId::from).collect(toSet()));
}
}
}
2 changes: 1 addition & 1 deletion service/imagebuilder/serializers.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions service/imagebuilder/types/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8fcb670

Please sign in to comment.