Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check for sso-session is present or not. #1845

Closed
skmcgrail opened this issue Sep 15, 2022 · 2 comments · Fixed by #1903
Closed

Need to check for sso-session is present or not. #1845

skmcgrail opened this issue Sep 15, 2022 · 2 comments · Fixed by #1903
Assignees
Labels
bug This issue is a bug.

Comments

@skmcgrail
Copy link
Member

func (c *SharedConfig) hasCredentials() bool {
switch {
case len(c.SourceProfileName) != 0:
case len(c.CredentialSource) != 0:
case len(c.CredentialProcess) != 0:
case len(c.WebIdentityTokenFile) != 0:
case c.hasSSOConfiguration():
case c.Credentials.HasKeys():
default:
return false
}
return true
}

@skmcgrail skmcgrail changed the title Need to check for sss-session is present or not. Need to check for sso-session is present or not. Sep 15, 2022
@RanVaknin RanVaknin added bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. labels Sep 19, 2022
@skmcgrail skmcgrail removed the needs-review This issue or pull request needs review from a core team member. label Oct 19, 2022
@isaiahvita
Copy link
Contributor

specifically, it looks like the hasSSOConfiguration function currently assumes a legacy SSO configuration.

func (c *SharedConfig) hasSSOConfiguration() bool {
switch {
case len(c.SSOAccountID) != 0:
case len(c.SSORegion) != 0:
case len(c.SSORoleName) != 0:
case len(c.SSOStartURL) != 0:
default:
return false
}
return true
}

when it should check for both the legacy SSO configuration and the new SSO configuration that was introduced with the SSO Token Provider

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants